Maga D. Zandaqo

Results 29 comments of Maga D. Zandaqo

`ReferenceError: jest is not defined` I'm guessing this is due to the missing `@jest/globals`

> Similar remark re [current params](https://github.com/lit/lit/blob/23529e5006636be50ad9d00620c3f7086bd34063/packages/labs/router/src/routes.ts#L107) > > There might be scenario where you would like to access it. For instance, checking parameters from _parentRoutes in nested route scenario. There...

With `Routes#_currentRoute` becoming private, checking the active route is nigh impossible. Can we have a getter for the current route? It's just a couple lines of code, if there are...

Wouldn't a sorted array of objects be effectively that? Something like this: ```typescript class SortedMap extends SortedArray { static compare(a: { key: K, value: T}, b: { key: K, value:...

```typescript const sorted = new SortedArray(...array) ``` Just use the constructor, it doesn't trigger sorting. EDIT: > Is that the preferred solution? Yes, at least for now, I have to...

Yes, typing can probably be improved, but inheriting from the DataView/TypedArray was a deliberate choice. I want to re-use their methods without writing custom logic for binary writing/reading (or keeping...

The uniqueness here is judged by the comparator function, if it returns 0 the elements are the same, as it does here: ```ts if (b.ts == a.ts) return 0; ```...

Well, then return `0` from the second check where you consider them to be duplicates.

Same problem here. Is there a planned version for this fix? Kinda trivial thing but breaks the UX quite badly.