masscan icon indicating copy to clipboard operation
masscan copied to clipboard

Why keep structs weirdly?

Open rew1nter opened this issue 10 months ago • 1 comments

Why do you have ports listed in the masscanresult when you already have it in hosts? :/


	MasscanResult struct {
		Hosts []Hosts `json:"hosts"`
		Ports []Ports `json:"ports"`
	}

	// Hosts  masscan hosts output struct
	Hosts struct {
		IP        string  `json:"ip"`
		Ports     []Ports `json:"ports"`
		Timestamp string  `json:"timestamp"`
	}

	// Ports  masscan ports output struct
	Ports struct {
		Port   int    `json:"port"`
		Proto  string `json:"proto"`
		Status string `json:"status"`
		Reason string `json:"reason"`
		TTL    int    `json:"ttl"`
	}

)

why not just do this?


	MasscanResult struct {
		Hosts []Hosts `json:"hosts"`
	}

	// Hosts  masscan hosts output struct
	Hosts struct {
		IP        string  `json:"ip"`
		Ports     []Ports `json:"ports"`
		Timestamp string  `json:"timestamp"`
	}

	// Ports  masscan ports output struct
	Ports struct {
		Port   int    `json:"port"`
		Proto  string `json:"proto"`
		Status string `json:"status"`
		Reason string `json:"reason"`
		TTL    int    `json:"ttl"`
	}

rew1nter avatar Sep 07 '23 17:09 rew1nter

Sorry, the code is a bit old, your suggestion is better👏

zan8in avatar Sep 08 '23 00:09 zan8in