afrog
afrog copied to clipboard
zan8in
Update Octicons to v10.0.0
Summary
GitHub has recently released some new snazzy octicons, and would love to see them in Atom!
Motivation
To look more cutting edge 😍
Describe alternatives you've considered
Additional context
I would like to work on this as part of Hactoberfest and to start my experience on open source. I'm working on Atom local setup and can you kindly explain to me what to achieve in this issue?. that would be helpful for me to get a start.
Hey @gopipofficial the best place to start would be https://github.com/atom/atom/blob/0f2975930e506785c05068a1c57934160e094e10/static/variables/octicon-mixins.less#L36-L48
However looking at the direction that github took to deliver octicons as svg rather than icon fonts, working on this would require a rework on how atom uses the icons.
Apologies I miss labeled this issue. If you are still willing to proceed working on this issue let me know.
I'll try my level best to achieve this before to start I'm having local setup issue working on it. Please give me sometime.
Yes, @pavan5555 ill be working on it. Unfortunately, I'm facing an atom local setup issue. Once I fixed that ill start working on it.
@sadick254 I regret to say this, I'm still facing an issue with the local setup. I've opened one issue for getting help on that.
@Moe82 my local environment setup issue was fixed with the help of @sadick254 and now I started looking into the issue.
@sadick254 thanks for your input on setting up the local env. now its up and wanted to fix this issue. the issue is to change all the icons in the Atom from font icon to new octicons respectively right ???
Wow that was so help help full for me thnaks for sharing such a valuable information i use these tips on my website SolankiGaming! and I am able to generate a lot of traffic.
It's very informative. I really appreciate your works for the newbies. I follow these on my Blog HindiDigit
Thank you so much for this article. it was very informative. i really hope you continue making great content like this. i will definently follow these tips on my blog: Gadgetsglam
@cloudguruab this won't be easy. Octicons quit using fonts in v5 and went with svgs. But you can try if you want to.
I found 2 resource in case it helps:
https://docs.brainstormforce.com/how-to-convert-svg-file-into-a-font-icon/
https://stackoverflow.com/questions/13278707/how-to-convert-svg-files-to-a-font/
Would performance have a hit if we instead replaced the spans with SVGs?
Looks like it is an error in https://github.com/atom/atom/blob/978843584aaeb25e25fbe53693bb9d227b4bfed1/script/lib/spawn-sync.js#L17
If you delete ${result.args.join(' ')} locally it should not throw an error.
WHEN WILL YOU FUCKING STOP YOUR SPAMS, HERE, ALL OF YOU? I UNSUSCRIBED MILLION TIMES AND STILL RECIEVING YOUR SHIT !
LAST ADVISE : OR YOU ALL STOP TO SPAM MY FUC.KING MAILBOX WITH ALL YOUR SHIT, OR I FUCKING BRING YOU TO COURT !
ENOUGHT CLEAR ?
