zammad
Feature: Add manual OpenID Connect settings
This PR add several form fields to auth_openid_connect_credentials so users can configure manually OpenID Connect (without the discovery endpoint). This follows up on a discussion on Zammad community hub. There is no corresponding issue so let me know if you need me to open one.
I just realized you use Rubocop, I'm going to lint the code a bit.
EDIT: it's done!
@pirhoo Thanks for this contribution. We need to clarify from product context if we want to implement this. But I think one thing is more or less clear, not all fields should always be visible. So we need some hide/show mechanism, when really the "manual" configuration is used.
Understood!
If you think this PR is relevant, I'd be happy to move those settings to an "advanced settings" hidden block. Although I'm could not find how to do it with setting's form.
Dear Zammad team,
I hope you had a good summer. Did you have the time to consider merging my PR? I'll be happy to make some tweaks if that can help you to take a decision.
Have a great week!
I think we still need to investigate how we can add in a easy way conditional fields in the generic settings implementation.
I think we still need to investigate how we can add in a easy way conditional fields in the generic settings implementation.
Yes, true. We need it, otherwise the configuration section for OpenID is too complicated.
However, @pirhoo, thanks for this pull request!
