zammad icon indicating copy to clipboard operation
zammad copied to clipboard

UserAgent logs too much content

Open mantas opened this issue 2 years ago • 5 comments

Used Zammad Version

6.2

Environment

  • Installation method: any
  • Operating system (if you're unsure: cat /etc/os-release ): any
  • Database + version: any
  • Elasticsearch version: any
  • Browser + version: any

Actual behaviour

UserAgent logs all responses for some types of requests. Including content of successful responses. Which may generate a lot of noise and take up resources. However, in some cases it may be useful for debugging.

Expected behaviour

To be discussed. For example, UserAgent shall log errors only.

Steps to reproduce the behaviour

Use one of the following features:

  • External data source
  • Idoit integration
  • Github/Gitlab integration
  • SAML
  • Webhook

Support Ticket

No response

I'm sure this is a bug and no feature request or a general question.

yes

mantas avatar Nov 24 '23 19:11 mantas

@dk @mgruner do you have anything to add?

mantas avatar Nov 24 '23 19:11 mantas

Nah I'm good thank you ... wrong dk most probably, though 🤣

dk avatar Nov 24 '23 21:11 dk

Nah I'm good thank you ... wrong dk most probably, though 🤣

Oh crap… Sorry dude. Thank you for pointing it out 😁

mantas avatar Nov 26 '23 08:11 mantas

@mantas AFAIR Expected Behaviour must first be specified. We discussed logging errors by default, but also the possibility for an admin to turn on logging (globally?) for all requests for debugging purposes, e.g. via ENV variable. This should be clarified by product first.

mgruner avatar Nov 27 '23 07:11 mgruner

@mgruner Yes. That's why I added specification required label. Edited to be more clear.

ping the real @dominikklein :)

mantas avatar Nov 27 '23 08:11 mantas