zammad icon indicating copy to clipboard operation
zammad copied to clipboard

feature: fix #3380, now category display how many deep answers contains

Open FiloSpaTeam opened this issue 4 years ago • 28 comments

FiloSpaTeam avatar Jul 12 '21 20:07 FiloSpaTeam

Hi @FiloSpaTeam

Could you post a screenshot how it looks after the change?

mantas avatar Jul 15 '21 06:07 mantas

Schermata da 2021-07-15 11-56-07

Alternative: Schermata da 2021-07-15 11-58-38

With:

hr {
width: 90%;
border: 0;
border-top: 1px solid #eee;
}

FiloSpaTeam avatar Jul 15 '21 09:07 FiloSpaTeam

Personally like the hr approach to give some feedback. :)

MrGeneration avatar Jul 15 '21 10:07 MrGeneration

@mrflix what do you think?

mantas avatar Jul 15 '21 10:07 mantas

So i should fix the pull request with hr?

FiloSpaTeam avatar Jul 16 '21 14:07 FiloSpaTeam

Let's wait for response from @mrflix who is overlooking UI :)

mantas avatar Jul 16 '21 15:07 mantas

I don't like that the amount has the same visual hierarchy level as the title. The title is way more important. So that amount should be smaller, lighter or both. The horizontal divider looks good.

mrflix avatar Jul 19 '21 16:07 mrflix

Schermata da 2021-07-19 18-52-17

This applying a class small on span

Schermata da 2021-07-19 18-53-41

This with font-weight: 300

FiloSpaTeam avatar Jul 19 '21 16:07 FiloSpaTeam

Lighter → I meant in terms of color. I'd gray it out a bit. Maybe we just gray it out and don't use the <hr> to make it look like the tiles on the dashboard:

Screenshot 2021-07-19 at 18 56 46

mrflix avatar Jul 19 '21 16:07 mrflix

Ok understood

FiloSpaTeam avatar Jul 19 '21 17:07 FiloSpaTeam

Schermata da 2021-07-19 19-06-48

This applying stat-label and stat-detail classes

FiloSpaTeam avatar Jul 19 '21 17:07 FiloSpaTeam

Looks good! I'm not sure if we should reuse the classes here. I'd rather go with creating own classes for this case and set the colors (title #444a4f, detail #b4b7b9) there:

Screenshot 2021-07-20 at 10 32 09

Screenshot 2021-07-20 at 10 33 34

mrflix avatar Jul 20 '21 08:07 mrflix

What do you guys think about adopting this for public KB UI?

mantas avatar Jul 20 '21 16:07 mantas

How would this help a user? If I look at the knowledge bases of big players, none of them has a "number of answers" indicator on their top level:

Google Screenshot 2021-07-23 at 08 30 51

Facebook Screenshot 2021-07-23 at 08 31 33

Apple Screenshot 2021-07-23 at 08 31 11

mrflix avatar Jul 23 '21 06:07 mrflix

This has been requested by a fairly big customer. However, we've seen this kind of request in the past as well.

Does it help the end user? I don't know.

MrGeneration avatar Jul 23 '21 07:07 MrGeneration

If I was making the decision, I'd make this an opt-in setting. Personally I don't like showing the count, but there's enough noise to give people what they're asking for :)

mantas avatar Jul 23 '21 19:07 mantas

This has been requested by a fairly big customer.

Did the customer ask for the answer count in the public KB or the internal KB?

mrflix avatar Jul 29 '21 06:07 mrflix

Sorry for the wait, thank you for your patience!

We've came to point that this would be useful to show internal for agents. On public interface there should be a knowledge base admin setting (which defaults to off) that allows administrators to enable the answer counter on public pages.

We feel that a counter on public pages may be too technical for most of our user base but also feel that it could come in handy for others.

MrGeneration avatar Jan 05 '22 13:01 MrGeneration

Don't worry, so i need to add a simple check input (default to off) to enable/ disable the feature, right?

FiloSpaTeam avatar Jan 05 '22 22:01 FiloSpaTeam

Yes, you're looking for Settings on this regard. @mantas should be able to give you pointers in case you're getting lost. 🙏

MrGeneration avatar Jan 05 '22 22:01 MrGeneration

I'll take some times in the next weeks :)

FiloSpaTeam avatar Jan 05 '22 23:01 FiloSpaTeam

@FiloSpaTeam do you think that you can work on this the next time, otherwise we can maybe try to add the missing things on our side.

dominikklein avatar Mar 18 '22 09:03 dominikklein

I'll schedule it for the 21/03, sorry for my delay. I had some troubles with other sources

FiloSpaTeam avatar Mar 18 '22 09:03 FiloSpaTeam

@FiloSpaTeam do you think that you can work on this the next time, otherwise we can maybe try to add the missing things on our side.

What i did today:

  • created a migration for the dedicated column inside the table knowledge_bases
  • create a new tab under knowledge settings
  • add checkbox using the js deidcated for custom input

What i need to understand is: how can i access in JS, the knowledge base active object?

FiloSpaTeam avatar Mar 18 '22 20:03 FiloSpaTeam

Hi @FiloSpaTeam

Where are you trying to access the active KB object?

mantas avatar Mar 18 '22 20:03 mantas

Inside here:

app/assets/javascripts/app/views/knowledge_base/_reader_list_item.jst.eco

FiloSpaTeam avatar Mar 18 '22 21:03 FiloSpaTeam

See bottom of reader_list_item.coffee ;)

mantas avatar Mar 19 '22 06:03 mantas

See bottom of reader_list_item.coffee ;)

i found a way, thanks for the suggestion. The code is up :)

I needed to fix the checkbox jst.eco too because when you submit a checkbox unchecked, the checkbox is not submited in any way (this is not a bug essentially but a HTML feature), so i added an hidden input with a false value, the value will be replaced by the checkbox automatically if checked :)

FiloSpaTeam avatar Mar 19 '22 12:03 FiloSpaTeam

Closed via 74ee3b91.

mgruner avatar Sep 02 '22 11:09 mgruner