tfhe-rs icon indicating copy to clipboard operation
tfhe-rs copied to clipboard

feat(integer): improve {overflowing_}scalar_add/sub

Open tmontaigu opened this issue 1 year ago • 1 comments

  • [x] check benches
  • [x] handles trivial oveflow (scalar > ciphertext max)
  • [x] modifiy test to use non fixed number of blocks
  • [x] remove commented code
  • [ ] add some docs

tmontaigu avatar Jul 26 '24 15:07 tmontaigu

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Ubuntu. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] avatar Jul 29 '24 15:07 cla-bot[bot]

@cla-bot check

tmontaigu avatar Aug 14 '24 10:08 tmontaigu

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Aug 14 '24 10:08 cla-bot[bot]