fhevm icon indicating copy to clipboard operation
fhevm copied to clipboard

test(coprocessor): typo on maximimum_compact_inputs_upload in Update utils.rs

Open HarleyQeen opened this issue 5 months ago • 10 comments

In "maximimum_compact_inputs_upload: 10" typo error: Fix: maximimum ---> maximum

HarleyQeen avatar Jul 19 '25 13:07 HarleyQeen

Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @HarleyQeen on file. In order for us to review and merge your code, please sign:

  • For individual contribution: our CLA
  • for Bounty submission, if you are an individual: our T&C
  • for Bounty submission, if you are a company: our T&C to get yourself added.

If you already signed one of this document, just wait to be added to the bot config.

cla-bot[bot] avatar Jul 19 '25 13:07 cla-bot[bot]

@cla-bot check

aquint-zama avatar Jul 20 '25 06:07 aquint-zama

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Jul 20 '25 06:07 cla-bot[bot]

@rudy-6-4 merge pls

HarleyQeen avatar Jul 29 '25 06:07 HarleyQeen

@rudy-6-4 merge pls

Hi @HarleyQeen

  1. I am waiting for CI to check everything.And as far as I understand it should be red. coprocessor/src/daemon_cli.rs has not been updated according to your change.

  2. And also I can't merge due to commit title. You must first fix it. Look at the "Merging is blocked" status. " Commit message must match a given regex pattern: ^(build|chore|ci|docs|feat|fix|perf|refactor|revert|style|test)((coprocessor|host-contracts|gateway-contracts|library-solidity|kms-connector|sdk|test-suite|charts|common))(!)?: [\s\S]*$ " In your case that woud be something like "test(coprocessor): typo on maximimum_compact_inputs_upload"

rudy-6-4 avatar Jul 29 '25 13:07 rudy-6-4

You must fix all occurences: https://github.com/zama-ai/fhevm/actions/runs/16389205396/job/46948602434?pr=602#step:9:1265 error[E0560]: struct daemon_cli::Args has no field named maximum_compact_inputs_upload --> coprocessor/src/tests/utils.rs:103:9 | 103 | maximum_compact_inputs_upload: 10, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unknown field | help: a field with a similar name exists | 103 | maximimum_compact_inputs_upload: 10, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

rudy-6-4 avatar Jul 29 '25 13:07 rudy-6-4

@rudy-6-4 tell me pls now good or I need change some or fix?

HarleyQeen avatar Jul 30 '25 07:07 HarleyQeen

@aquint-zama hi can we fix it together?

HarleyQeen avatar Aug 26 '25 14:08 HarleyQeen

@HarleyQeen sure are you on our discord?

aquint-zama avatar Aug 26 '25 15:08 aquint-zama

@aquint-zama yes (fagos) or you can text here

HarleyQeen avatar Aug 26 '25 19:08 HarleyQeen

Replaced by https://github.com/zama-ai/fhevm/pull/852 to fix compilation

rudy-6-4 avatar Sep 10 '25 12:09 rudy-6-4