remote-redux-devtools icon indicating copy to clipboard operation
remote-redux-devtools copied to clipboard

`serialize: {immutable: Immutable}` option

Open unindented opened this issue 8 years ago • 5 comments
trafficstars

On redux-devtools-extension, there's the option to pass serialize: {immutable: Immutable}. That option is not documented on this repo... Is there a reason for that?

unindented avatar Apr 28 '17 02:04 unindented

@unindented - If I'm not mistaken, it's not supported. The standard redux-devtools-extension is using his remotedev-serialize

@zalmoxisus - What approach do you suggest we take - I could possibly help with a PR since I need to use this.

tsaiDavid avatar May 03 '17 17:05 tsaiDavid

It was added in remotedev-utils. A pr to pass this option, wold be much appreciated.

zalmoxisus avatar May 03 '17 17:05 zalmoxisus

@zalmoxisus Wow, thanks for the quick reply - thanks for pointing that out! Sounds good, I can work on that. Will I have to use remotedev-utils/src/importState.jsat all then? Thanks for all your work 👍

tsaiDavid avatar May 03 '17 17:05 tsaiDavid

We need just to import getSeralizeParameter in here and use like so:

const serialize = getSeralizeParameter(config)

Then pass it to stringify from remotedev-utils, which should be used instead of jsan's stringify.

Also we'll need to use importState instead of https://github.com/zalmoxisus/remote-redux-devtools/blob/master/src/devTools.js#L99-L101.

Basically, the long-term plan is to move all the common part from Redux DevTools Extension into remotedev-utils and reimplement it here.

zalmoxisus avatar May 03 '17 18:05 zalmoxisus

@tsaiDavid any progress here? How can I help? I don't know enough about this project's internals to understand @zalmoxisus's steps. If somebody can detail them even more I'll try.

unindented avatar May 29 '17 00:05 unindented