Mario Salgado

Results 44 comments of Mario Salgado

Awesome @niksteff, I will get started with a v2 package for this PR ASAP, then. I agree it's the best approach to promote backwards compatibility :D

@YoshiyukiMineo Thank you for your time and consideration! I've updated my fork to separate the generics implementation into a new module within this repo (as `github.com/sony/gobreaker/v2`). Please take your time...

> Is there a reason prefer the `v2` directory strategy over using a `v2` tags? Hi @pior The proposal allows new (breaking) changes to be added while still keeping the...

Bump. I have the understanding that, with this same issue, the commands run when called as root (with tsudo prefixed). I have noticed the Compiler (javac) works - it created...

Note: the force-push was to add the sign-off mark to the commit, in compliance with the DCO :)

Since it applies changes to the code with the --fix flag, I thought the caller should execute the make target beforehand (even if just adding newlines) :D It should be...

> Hi @zalgonoise, I see that you wrote all test cases manually for the logger. Go provides [`slogtest`](https://pkg.go.dev/golang.org/x/exp/slog/slogtest), which tests every function of a slog handler. We could use this...

> I just found this one minor simplification. Nice job! @johannes-riecken awesome input! Thanks for noticing, I don't know how I let that slide! :D

Looking into this (and other) PR's CI jobs, it seems that the semgrep one is failing: [example job](https://github.com/SchwarzIT/go-template/actions/runs/6787873829/job/18455989520) ``` Prepare workflow directory Prepare all required actions Getting action download info...

@MarvinJWendt another update regarding `slogtest` :D Unfortunately, we are unable to use it for this particular wrapper / decorator. The problem with `slogtest` is that it [has zero tests using...