zappr icon indicating copy to clipboard operation
zappr copied to clipboard

ISSUE-544: Add support for native approvals, fix validation bug, fix typos

Open GeorgySerga opened this issue 6 years ago • 4 comments

An attempt to fix: https://github.com/zalando/zappr/issues/544 This is a draft, work in progress. Code is working (expected to be working), no tests or toggle is implemented. More on the changes and reasoning would be inside inline comments. Thanks for reviews.

GeorgySerga avatar Oct 25 '19 20:10 GeorgySerga

@stoewer Thank you for the review. I'll try to comment/fix issues asap, but it might take longer than usual as I'm taking a long vacation soon.

GeorgySerga avatar Nov 11 '19 16:11 GeorgySerga

@GeorgySerga are you still working on this PR? if not maybe I can give it a shot?

louis993546 avatar Mar 11 '20 14:03 louis993546

@louistsaitszho Hello! You're right, I've been lazy :) The code worked for me (counts native approvals and +1s), but in order to go through: need to make CR changes, write tests, add a toggle and update readme here, I think. If you want to contribute, sure thing, I can help as well, explaining some decisions, or setting things up (4 months passed, wow).

GeorgySerga avatar Mar 11 '20 14:03 GeorgySerga

3 more years passed. Is there any update on that?

red-avtovo avatar May 23 '23 09:05 red-avtovo