zappr
zappr copied to clipboard
add oneOf PR label Check
fixes https://github.com/zalando/zappr/issues/562
i have to check later further why tests are failing. if someone else spots something already in the meantime, please let me know, highly appreciated ... when fixed, i will open a new clean PR probably
@fokusferit @lotharschulz or someone else: any chance you can have a look and point me to what's wrong here? i'm still struggling to set up zappr locally, so any help here to get this already merged is appreciated ..
@drummerwolli well it looks like somehow the tests are not getting into the if block to execute createStatePayload
. I didn't check out the branch yet, but did you check just with console.log
that when running generateStatusRequired
is triggered it is definitely returning and calling createStatePayload
even when from code base I can't see a real difference, maybe some config value is not correctly provided. But will try to check the next days.
@drummerwolli Hi, Is this pr still relevant?
i lack the time to investigate more here, but i would still like to see the feature implemented @rashamalek
:+1:
👍