zappr icon indicating copy to clipboard operation
zappr copied to clipboard

add oneOf PR label Check

Open drummerwolli opened this issue 5 years ago • 5 comments

fixes https://github.com/zalando/zappr/issues/562

drummerwolli avatar Feb 22 '19 10:02 drummerwolli

i have to check later further why tests are failing. if someone else spots something already in the meantime, please let me know, highly appreciated ... when fixed, i will open a new clean PR probably

drummerwolli avatar Feb 22 '19 13:02 drummerwolli

@fokusferit @lotharschulz or someone else: any chance you can have a look and point me to what's wrong here? i'm still struggling to set up zappr locally, so any help here to get this already merged is appreciated ..

drummerwolli avatar Mar 01 '19 14:03 drummerwolli

@drummerwolli well it looks like somehow the tests are not getting into the if block to execute createStatePayload. I didn't check out the branch yet, but did you check just with console.log that when running generateStatusRequired is triggered it is definitely returning and calling createStatePayload even when from code base I can't see a real difference, maybe some config value is not correctly provided. But will try to check the next days.

fokusferit avatar Mar 06 '19 17:03 fokusferit

@drummerwolli Hi, Is this pr still relevant?

rashamalek avatar May 20 '19 14:05 rashamalek

i lack the time to investigate more here, but i would still like to see the feature implemented @rashamalek

drummerwolli avatar May 21 '19 11:05 drummerwolli

:+1:

drummerwolli avatar Nov 30 '23 08:11 drummerwolli

👍

tkrop avatar Nov 30 '23 11:11 tkrop