zappr Approval Pattern - case insensitive

Approval Pattern - case insensitive

Open jglapa opened this issue 6 years ago • 2 comments

https://github.com/zalando/zappr/blob/641814d32ef6ae67f691486394465c43a8750348/server/checks/CommitMessage.js#L68

Does this mean that the regexp pattern is case sensitive? Could we make that configurable?

Jun 19 '18 10:06 jglapa

The approval pattern is ":+1:" by default, so case does not matter in that case :smirk:

Jun 19 '18 17:06 hjacobs

I know about the default one but I want it to be approved and Approved and APPROVED. Any possibility to do it without ORs in the regexp?

Jun 19 '18 19:06 jglapa