zappr icon indicating copy to clipboard operation
zappr copied to clipboard

Published 20 hours ago • verified publisher icon zalando

Feature: PR Title contains Issue number

Open fragsalat opened this issue 7 years ago • 2 comments

We would like to enforce our PR titles to follow the same pattern as the commits because if you make a squash merge the PR title is by default taken for the commit message which often leads to a failing commit message check which is only fixable via rebasing. A PR title would be much easier to fix.

Would you like to have such a feature and merge a PR for this?

fragsalat avatar Jul 05 '17 11:07 fragsalat

@fragsalat Please note that the commit message check is not longer required to meet compliance requirements. Only approval + specification check. Do you in this case still need this feature? Usually you get a proper "link" between PRs and issues, when you write "fixes #ISSUE_NUMBER" in the PR body.

harti2006 avatar Sep 20 '17 13:09 harti2006

Yeah because we decided to go with squash merges and feature and task branches and the PR title is used for the Commit message. So when you have a PR from a task into a feature branch with a pr title which doesn't match the commig message check the PR from feature to master branch will fail. Therefore I would like to have a check for the PR title as well.

fragsalat avatar Sep 21 '17 15:09 fragsalat