tech-radar icon indicating copy to clipboard operation
tech-radar copied to clipboard

chore: better support different number of rings

Open ggarber opened this issue 1 year ago • 2 comments

Better support for variable number of rings removing the hardcoded constant 4 in different places.

ggarber avatar Apr 02 '23 14:04 ggarber

Thanks for the PR. Do you have a branch with a fully working example? I tried to check out your branch and add a 5th ring and the change breaks due to undefined radius for the new ring.

A few more things will break:

  • cartesian_max uses index 3 which is a hardcoded 4-1
  • legend_calculation calculates the legend offsets and at least the calculation for dy needs to consider more rings via a formula with ring and 12 rather than the naive switch using mod 2

bocytko avatar Apr 02 '23 20:04 bocytko

Nice idea, going forward.

rishiraj88 avatar Apr 22 '24 04:04 rishiraj88