tech-radar
tech-radar copied to clipboard
chore: better support different number of rings
Better support for variable number of rings removing the hardcoded constant 4 in different places.
Thanks for the PR. Do you have a branch with a fully working example? I tried to check out your branch and add a 5th ring and the change breaks due to undefined radius for the new ring.
A few more things will break:
- cartesian_max uses index 3 which is a hardcoded 4-1
-
legend_calculation calculates the legend offsets and at least the calculation for
dy
needs to consider more rings via a formula withring
and12
rather than the naive switch usingmod 2
Nice idea, going forward.