skipper icon indicating copy to clipboard operation
skipper copied to clipboard
verified publisher icon zalando

feat: added leakage verification

Open alexandreliberato opened this issue 3 years ago • 3 comments

To avoid defects and resource waste we can use uber's goleak to detect goroutine leakages.

Added

  • uber-go/goleak library
  • main_test files to test leakage in all test package tests (eskipfile, filters/serve and dataclients/kubernets)

Related to #1989

alexandreliberato avatar Aug 07 '22 19:08 alexandreliberato

Related to #2051

alexandreliberato avatar Aug 07 '22 19:08 alexandreliberato

Please do rebase with signoff to fix DCO, thanks!

szuecs avatar Aug 08 '22 19:08 szuecs

@alexandreliberato can you please pull and rebase your commit on the current master? It will fix the test errors, that blocks the PR from merging. And then you need to run git amend --signoff before push -f and have the DCO also fixed.

szuecs avatar Aug 23 '22 10:08 szuecs

https://github.com/zalando/skipper/pull/2128

szuecs avatar Nov 08 '22 19:11 szuecs