skipper icon indicating copy to clipboard operation
skipper copied to clipboard

net.Error.Temporary() is Deprecated in Go 1.18

Open mikkeloscar opened this issue 3 years ago • 5 comments

In Go 1.18 the net.Error.Temporary() method we use in a few places is deprecated. We should consider removing it.

For now we upgraded to 1.18 ignoring the deprecation

mikkeloscar avatar Mar 30 '22 11:03 mikkeloscar

I believe given the package documentation, Temporary can be replaced by Timeout since most temporary errors are just timeout. This can be fixed by a simple refactor by replacing the method with the new one. In places that we have both, we can just drop the Temporary.

demonCoder95 avatar Nov 16 '22 19:11 demonCoder95

We should review our production logs for the relevant error strings and check if we see something or if you are right with your replacement suggestion.

szuecs avatar Nov 16 '22 20:11 szuecs

That's a good idea! I can take a look to double-check before we move ahead with the PR.

demonCoder95 avatar Nov 16 '22 20:11 demonCoder95