skipper icon indicating copy to clipboard operation
skipper copied to clipboard

Benchmark and optimize the apiUsageMonitoring() filter

Open aryszka opened this issue 6 years ago • 2 comments

In certain cases, unnecessarily long time spent was observed in the apiUsageMonitoring() filter. It should be benchmarked and if optimization possibilities were found, then implemented.

One possible optimization can be to avoid caching of the concatenated keys and see if the concatenating them on-the-fly turns out to be cheaper than caching them in a sync.Map.

aryszka avatar Oct 09 '19 13:10 aryszka

After looking on many request-filter traces, I come to the conclusion, that the performance of the apiUsageMonitoring-filter seems within expected bounds. There surely is room for improvement, but it is unlikely, that it is the reason of the experienced problems.

tkrop avatar Oct 11 '19 10:10 tkrop

@tkrop can you share your expected bounds? We might want to document these boundaries, if you have some in mind. :)

szuecs avatar Oct 11 '19 12:10 szuecs