problem icon indicating copy to clipboard operation
problem copied to clipboard
verified publisher icon zalando

#426 module-info.java is placed in the wrong jar

Open viktor44 opened this issue 2 years ago • 3 comments

Description

Fixes #426

File module-info.class was moved from META-INF/versions/9 to the root folder of the jar.

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my changes.

viktor44 avatar Aug 04 '23 21:08 viktor44

I will take a look in the next days.

MALPI avatar Sep 02 '23 06:09 MALPI

Up! 😄

viktor44 avatar Nov 17 '23 20:11 viktor44

@viktor44 hey there, sorry for the long silence. The PR looks good, but I do have some questions.

mvn install -Dmaven.test.skip=true

Running this locally, adds the module-info.class to META-INF/versions/9/module-info.class. Maybe we somehow missed publishing this properly in the previous releases. Reading moditect README, setting jvmVersion to 9 or higher increases the compatiblity with old jar-scanning tools (which by now is an obsolete argument, I guess)

Secondly, let's upgrade the maven plugin to the current stable version.

And finally, please sign-off your commit, using git commit --amend --signoff.

otrosien avatar Jul 17 '24 12:07 otrosien