Java 9 support

[spac-valentin]

jackson-datatype-problem and org.zalando.problem cannot be used in the same module as

Module 'my.module' reads package 'org.zalando.problem' from both 'jackson.datatype.problem' and 'problem'

Detailed Description

I am trying to build a spring app using java 13 with modules and noticed that there is no support for it

Context

Possible Implementation

I think the fix is as easy as adding an Automatic-Module-Name: <module name> entry to the library's MANIFEST.MF

Your Environment

• Version used: 0.25.2

[bhatnagarm]

Hi All, I'm facing the same issue and can't use the library just because of this. Is there any updates on this ?

[whiskeysierra]

If this is just the manifest entry, then it's easy. If there is a split package issue then it would be a breaking change.

[spac-valentin]

If this is just the manifest entry, then it's easy. If there is a split package issue then it would be a breaking change.

Unfortunately, it is a split package issue. You can try patching the module using --patch-module

[whiskeysierra]

I decided to tackle this before a potential 1.x release, since we're technically free to introduce breaking changes while we're still at 0.x.

[whiskeysierra]

I released 0.26.0-RC.0 with Java 9 support.

[whiskeysierra]

@spac-valentin @bhatnagarm Have you tried the RC?

[adovbnya]

@whiskeysierra

I released 0.26.0-RC.0 with Java 9 support.

In case when problem-spring-web is used, then problem & jackson-datatype-problem will be obtained transitively, but problem-spring-web:0.26.0-RC.0 is not released. So a Java 9 support patch is required for the entire dependency tree of the "problem" library (at least starting with problem-spring-web). Could you please release such a patch for all "problem" libs dependencies?

Dependency tree:

[whiskeysierra]

problem and problem-spring-web don't share the same version. You need to maintain separate versions for those two dependencies.

On Tue, 22 Dec 2020, 16:07 Alexander Dovbnya, [email protected] wrote:

@whiskeysierra https://github.com/whiskeysierra

I released 0.26.0-RC.0 with Java 9 support.

In case when problem-spring-web is used, then problem & jackson-datatype-problem will be obtained transitively, but problem-spring-web:0.26.0-RC.0 is not released. So a Java 9 support patch is required for the entire dependency tree of the "problem" library (at least starting with problem-spring-web). Could you please release such a patch for all "problem" libs dependencies?

Dependency tree: [image: image] https://user-images.githubusercontent.com/6270835/102902279-75052300-4477-11eb-9787-a3dd8cae1c06.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zalando/problem/issues/201#issuecomment-749586986, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADI7HLVJ6ZAPISTJZKQXKLSWCYZLANCNFSM4MEWWOHQ .

[adovbnya]

Yes, they use separate versions. But I'm only using problem-spring-web in my project and since it uses transitively problem and jackson-data-type-problem, I have no way to apply Java 9+ modules for my project ...

There is no patch for problem-spring-web that uses problem / jackson-data-type-problem of version 0.26.0-RC.0. I can't exclude/override these two dependencies on 0.26.0-RC.0 for any existing problem-spring-web, due to required package refactoring inside a jackson-data-type-problem.

It would also be nice to have a "Java 9 modules" patch version of problem-spring-web, that uses problem and jackson-data-type-problem version 0.26.0-RC.0

[whiskeysierra]

I can't exclude/override these two dependencies on 0.26.0-RC.0 for any existing problem-spring-web, due to required package refactoring inside a jackson-data-type-problem.

Is problem-spring-web directly relying on jackson-datatype-problem?

[whiskeysierra]

Ah, yes. We referece ProblemModule directly.

[whiskeysierra]

@adovbnya https://github.com/zalando/problem-spring-web/pull/576

[whiskeysierra]

@adovbnya I released 0.27.0-RC.0 with an updated dependency.