postgres-operator icon indicating copy to clipboard operation
postgres-operator copied to clipboard

fix(postgres-operator/deployment): Set 'nindent' to 8 for 'extraEnvs'

Open Mart-Kuc opened this issue 1 year ago • 1 comments

This PR fixes a template error in postgres-operator/deployment. If you want to use extraEnvs in values.yaml, the current indentation for extraEnvs causes the resulting deployment.yaml to break due to incorrect indentation.

The nindent value has been updated from 12 to 8.

Result with the old values.yaml (nindent 12):

Old-template

Result with the new nindent set to 8: New-template

Bumped Chart.yaml version to 1.13.1 but I'm not sure if it's correct

Mart-Kuc avatar Oct 17 '24 13:10 Mart-Kuc

That would be nice. We also hit that.

daleckystepan avatar Oct 22 '24 13:10 daleckystepan

Thanks for providing the fix. Could you please keep the version on the Chart.yaml? (see my comment)

FxKu avatar Oct 28 '24 17:10 FxKu

:+1:

FxKu avatar Oct 30 '24 08:10 FxKu