postgres-operator icon indicating copy to clipboard operation
postgres-operator copied to clipboard

Add a switch to turn off pvc retention policy (#2599)

Open bo0ts opened this issue 1 year ago • 5 comments

Fixes #2599

bo0ts avatar Apr 16 '24 11:04 bo0ts

Hm, isn't the retention policy something we always want to set in the long run. I've checked if it's also possible to retrieve the K8s/OpenShift ServerVersion to decide when to add it. Seems easier now than adding another config option which needs changes in many places (you haven't covered them all). And sorry, I wasn't aware that this feature is available in recent K8s versions.

FxKu avatar Apr 24 '24 06:04 FxKu

@FxKu I'm not sure about that. Is the k8s version enough? Don't we also need to check for the feature flag?

bo0ts avatar May 06 '24 13:05 bo0ts

That I don't know. But maybe also accessible like the ServerVersion. Can you check?

FxKu avatar May 17 '24 13:05 FxKu

any update?

angelsantillana94 avatar May 27 '24 13:05 angelsantillana94

Yeah, I have updated min required K8s version to 1.27 in the README :smiley: No, seriously, I would still suggest to add a simple if that checks the server version. I was hoping somebody from the community can show me how to do this. Over the last months we went through multiple K8s major version updates, so I would assume others can do it, too. 1.26- is already quite old.

FxKu avatar May 27 '24 16:05 FxKu

Hey, we do not need this feature anymore.

bo0ts avatar Sep 26 '24 06:09 bo0ts