postgres-operator icon indicating copy to clipboard operation
postgres-operator copied to clipboard

Secrets deletion config

Open dmotte opened this issue 1 year ago • 2 comments

This PR introduces a configuration option to provide a way to disable the deletion of Kubernetes secrets: enable_secrets_deletion (default true).

Ratio: see https://github.com/zalando/postgres-operator/issues/1736#issuecomment-1999567249

I think many people would love this feature. This also relates to #2579, which otherwise wouldn't make much sense, because attaching already-existing volumes to a brand new cluster doesn't work due to different secrets.

Inspired by #2579 (huge thanks to @FxKu)

dmotte avatar Mar 15 '24 13:03 dmotte

:+1:

FxKu avatar Apr 24 '24 06:04 FxKu

👍

namgk avatar Apr 24 '24 19:04 namgk

👍

idanovinda avatar May 10 '24 14:05 idanovinda

Thanks @dmotte

FxKu avatar May 10 '24 14:05 FxKu

@dmotte as far as I've understood this configuration is per operator. Is there a way to let the postgres cluster decide if it should keep the secret?

Yingrjimsch avatar Aug 30 '24 11:08 Yingrjimsch

@Yingrjimsch I think it can be implemented by adding a config option to the cluster manifest. To be honest I don't need it, but, if you want to give it a try, feel free to add me as a reviewer :)

dmotte avatar Aug 30 '24 13:08 dmotte

@dmotte I've added the functionallity here and mentioned you in the pull request, it is fairly simple but effective for our use case. If you have any suggestions just let me know :)

Yingrjimsch avatar Sep 05 '24 13:09 Yingrjimsch