postgres-operator icon indicating copy to clipboard operation
postgres-operator copied to clipboard

issue 1247: added ref to existing secret for logical backup s3

Open ErikLundJensen opened this issue 2 years ago • 2 comments

Added new parameter for logicalbackup configuration: logical_backup_s3_access_secret_name to solve #1247

The CRD for the operator is updated with new parameter. Documentation updated.

Note, I have updated the setting of "CLONE_AWS_SECRET_ACCESS_KEY" to be symmetric with the setting of AWS_SECRET_ACCESS_KEY.

I would need some help on running verify-codegen.sh which fails /Users/foobar/go/src/k8s.io/code-generator/generate-groups.sh: No such file or directory

ErikLundJensen avatar Jul 12 '22 09:07 ErikLundJensen

@FxKu can you look at the error

Jan-M avatar Aug 18 '22 12:08 Jan-M

:+1:

Jan-M avatar Aug 18 '22 12:08 Jan-M

Hey! Any chance this one will be merged?

okgolove avatar Aug 10 '23 09:08 okgolove

Is this still needed? We did work around the problem and forgot this pull request.

ErikLundJensen avatar Nov 22 '23 08:11 ErikLundJensen

As far as I remember I was also managed to find a workaround but proposed solution looks more clear.

okgolove avatar Nov 22 '23 14:11 okgolove

@ErikLundJensen what workaround did you find?

Yingrjimsch avatar Dec 01 '23 13:12 Yingrjimsch

Closing this PR in favor for #2051. I think, it should do the trick. Thanks again for your contribution.

FxKu avatar Jan 24 '24 17:01 FxKu