postgres-operator icon indicating copy to clipboard operation
postgres-operator copied to clipboard

Published 20 hours ago • verified publisher icon zalando

Feature/timelineid in clone section

Open Sudeepta92 opened this issue 2 years ago • 3 comments

Add timelineid in clone section in the cluster CRD.

In the cluster config we need timeline_id along with the existing possibility of timestamp and cluster name such as for eg:

clone: 
    cluster: my-cluster-xyz # original cluster
    timestamp: "2022-07-11T12:19:35+00:00"   
    clone_target_timeline: "2"

Sudeepta92 avatar Jul 11 '22 14:07 Sudeepta92

I think, we should not use the same name as the Spilo environment variable. We have also omitted the clone_ prefix from other variables. How about wal_timeline_id? Then it should be immediately clear what is meant here. Please, add this new field also to the CRD manifest (and chart). The field has to documented as well.

FxKu avatar Jul 12 '22 09:07 FxKu

I think, we should not use the same name as the Spilo environment variable. We have also omitted the clone_ prefix from other variables. How about wal_timeline_id? Then it should be immediately clear what is meant here. Please, add this new field also to the CRD manifest (and chart). The field has to documented as well.

The parameter name has been changed to "wal_timeline_id" from "clone_target_timeline". And I am working on the docs.

Sudeepta92 avatar Jul 18 '22 11:07 Sudeepta92

move to next milestone, because Spilo PR is still open

FxKu avatar Jan 05 '23 11:01 FxKu