pg_view icon indicating copy to clipboard operation
pg_view copied to clipboard

Refactor to psutil #2, added tests

Open rsiera opened this issue 6 years ago • 4 comments

Issue: https://github.com/zalando/pg_view/issues/60

Second part of refactoring to psutil. Includes tests and separating logic into classes which try not to break single object responsibility principle. This commit is preparation for last PR, which finally introduces psutil and makes pg_view platform independent.

rsiera avatar Aug 15 '17 12:08 rsiera

Hi @rsiera, thank you for the PR, I will take a look at it.

alexeyklyukin avatar Aug 15 '17 16:08 alexeyklyukin

Wow, this is still a lot of changes. Unfortunately, it takes more time to review this than I can allocate currently.

a1exsh avatar Nov 16 '17 10:11 a1exsh

Hello guys, can we back to this PR and finish the review process of that, so I can fix/apply changes ? I'm aware that it's quite big PR but these tests should make the project more stable and editable. + it finally solves #60 ;)

rsiera avatar Jul 12 '18 11:07 rsiera

@rsiera sorry, yes, that's a lot of code. Let me try to give it another shot in the upcoming days.

alexeyklyukin avatar Jul 12 '18 14:07 alexeyklyukin