logbook icon indicating copy to clipboard operation
logbook copied to clipboard

Published 20 hours ago • verified publisher icon zalando

response.body() is nullable

Open coltonenglish opened this issue 2 years ago • 1 comments

Description

OpenFeign's response object is nullable. All that is required here is to propagate the null where appropriate.

Motivation and Context

Notably a 404 with an empty response body trigger an NPE causing the library to blow up in ways that are unexpected.

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my changes.

coltonenglish avatar Jul 19 '22 16:07 coltonenglish

Hello @whiskeysierra. Is there any chance you can have a look at this and maybe kick of the CI/CD flows?

coltonenglish avatar Jul 26 '22 16:07 coltonenglish

Lol, I've done a similar fix at #1360

hgabor83 avatar Oct 14 '22 07:10 hgabor83

The fix is merged with https://github.com/zalando/logbook/pull/1362

kasmarian avatar Feb 10 '23 09:02 kasmarian