go-keyring icon indicating copy to clipboard operation
go-keyring copied to clipboard

feat: Add keyctl support. Closes #103

Open alexec opened this issue 4 months ago • 10 comments

This adds support for keyctl. This is only used if dbus does not work, otherwise it would break existing users.

It is not persistent, i.e. reboots loose data. This is desirable for my use case.

Closes #103.

alexec avatar Oct 17 '25 04:10 alexec

@szuecs please can I request review.

alexec avatar Oct 17 '25 04:10 alexec

@alexec

  • https://man7.org/linux/man-pages/man7/persistent-keyring.7.html
  • https://man7.org/linux/man-pages/man3/keyctl_get_persistent.3.html

ossenthusiast avatar Oct 17 '25 19:10 ossenthusiast

@ossenthusiast I asked Copilot and it says that does not survive reboots unfortunately. It does survive logins. I think it is the right direction.

alexec avatar Oct 18 '25 16:10 alexec

https://github.com/alexec/go-keyring/pull/1

alexec avatar Oct 18 '25 16:10 alexec

@mikkeloscar please can I request your review on this PR?

alexec avatar Oct 20 '25 21:10 alexec

I am a bit biased against crap comments by AI machines. Can you cleanup all useless comments? Some are useful, but scrolling over the code I would say it's a lot useless.

szuecs avatar Oct 23 '25 19:10 szuecs

@szuecs copilot has addressed your comments.

alexec avatar Oct 29 '25 02:10 alexec

@szuecs I've had Copilot move the composite provider to its own file and make the code easier to understand and revert the changes to existing comments.

alexec avatar Oct 31 '25 16:10 alexec

@szuecs can I please bump this to the top of your inbox? I'm hoping to use this on a project that will soon be ready to ship, but cannot run on dbus systems. It will only run where there is keyutils installed (headless systems).

Thank you.

alexec avatar Nov 14 '25 01:11 alexec

@szuecs can I bump this please? For the moment, I'm going to release a fork of this.

alexec avatar Nov 22 '25 16:11 alexec