swagger1st icon indicating copy to clipboard operation
swagger1st copied to clipboard

Remove WARN log lines for authentication failures

Open hjacobs opened this issue 10 years ago • 7 comments

Should not spam the log with WARNINGS about client's missing permissions. I propose changing these log lines to "INFO" and delete some places (e.g. if no auth was given).

See also https://github.com/zalando-stups/friboo/issues/34

This issue is about having clean logs. Internet-facing services will always get random requests without authentication --- this should not lead to WARNINGs in the logs as it does not trigger any action (developers will see WARNINGs but can't do anything about it as you cannot "control the internet" to avoid "random" requests from spiders etc).

WARNINGs should always be "actionable", i.e. I should be able to fix them as a developer.

hjacobs avatar Nov 03 '15 10:11 hjacobs

@LappleApple why did you close this?

hjacobs avatar Dec 02 '16 18:12 hjacobs

  1. It's written like a ticket for our use only; 2. nobody's touched it for +1 year.

lasomethingsomething avatar Dec 02 '16 18:12 lasomethingsomething

@LappleApple I still think the change makes sense (has nothing to do with our internal use) and I would leave this for the maintainers to decide.. :smirk:

hjacobs avatar Dec 02 '16 18:12 hjacobs

@hjacobs Noted. I removed your "we"

lasomethingsomething avatar Dec 02 '16 18:12 lasomethingsomething

@LappleApple as some background information: this issue is about having clean logs, internet-facing services will always get random requests without authentication --- this should not lead to WARNINGs in the logs as it does not trigger any action (developers will see WARNINGs but can't do anything about it as you cannot "control the internet" to avoid "random" requests from spiders etc).

WARNINGs should always be "actionable", i.e. I should be able to fix them as a developer.

hjacobs avatar Dec 02 '16 18:12 hjacobs

Thanks, @hjacobs: I've added it to your initial comment because it's nice context for anyone who stumbles across this issue and doesn't enjoy scrolling. :)

lasomethingsomething avatar Dec 02 '16 18:12 lasomethingsomething

Tagging the issue with "help wanted" as it shouldn't be hard and might thus be a nice way for new contributors to get started with the project.

sebastianpoeplau avatar Dec 05 '16 11:12 sebastianpoeplau