perron icon indicating copy to clipboard operation
perron copied to clipboard

Published 20 hours ago • verified publisher icon zalando-incubator

Update Node types and TypeScript

Open oporkka opened this issue 3 years ago • 5 comments

Updated Node types to latest v16 and TypeScript to latest v3

Updating the two libraries required some type changes in the implementation, notably the possibly breaking change of changing the type of ServiceClientRequestOptions.query from object | undefined to ParsedUrlQueryInput | undefined, which is more specific about the possible query parameter types. Clients of the library who defined earlier own types to structure query parameters, need to make sure the types extend ParsedUrlQueryInput

oporkka avatar Jan 11 '22 12:01 oporkka

:+1:

oporkka avatar Jan 11 '22 12:01 oporkka

:+1:

ponimas avatar Jan 13 '22 10:01 ponimas

:+1:

oporkka avatar Jan 13 '22 15:01 oporkka

It looks like the package version hasn't been updated in some time, should we bump it as part of this PR?

Joneser avatar May 13 '22 11:05 Joneser

👍

Joneser avatar May 13 '22 11:05 Joneser