kubernetes-log-watcher icon indicating copy to clipboard operation
kubernetes-log-watcher copied to clipboard

Scalyr: Use parse_lines_as_json for docker containers

Open mohabusama opened this issue 7 years ago • 3 comments

As described here: https://github.com/scalyr/scalyr-agent-2/releases/tag/v2.0.29

Also suggested here: https://github.com/zalando-incubator/kubernetes-on-aws/issues/620

mohabusama avatar Oct 04 '17 10:10 mohabusama

Hi @mohabusama,

I would also like to tackle this issue.

eicnix avatar Jul 09 '18 10:07 eicnix

Hi @eicnix ,, yep sure, please go ahead 😄

My only remark would be to make it configurable (WATCHER_SCALYR_PARSE_LINE_JSON).

I haven't really looked on how this works, but my main concern would be to make sure we do not break existing manifests which set a specific parser expecting the normal JSON message. If Scalyr agent will just add extra attributes and do not modify the message (which parsers depend on), then migration would be easier.

mohabusama avatar Jul 09 '18 16:07 mohabusama

@eicnix I didn't have much time to properly test this change. Could you try with this image:

registry.opensource.zalan.do/eagleeye/kubernetes-log-watcher:0.20-2-g5e1e18f

mohabusama avatar Jul 16 '18 09:07 mohabusama