kube-ingress-aws-controller icon indicating copy to clipboard operation
kube-ingress-aws-controller copied to clipboard

Published 20 hours ago • verified publisher icon zalando-incubator

Ingress > WAF > Don't create new stack

Open janavenkat opened this issue 2 years ago • 6 comments

WAF is already provisioned by client side. So that adding the parameter --aws-waf-web-acl-id controller should not create the new cloud formation/load-balancer stack or is there any restriction? that's why controller is creating new stack.

controller version: v0.12.5

janavenkat avatar Oct 18 '21 14:10 janavenkat

@janavenkat I think the controller creates a new stack because if you have many ingress and only a few use the waf annotation, we make sure that the rest will stay on the old load balancer and we create a new one for the new configuration. Does it make sense to you?

szuecs avatar Oct 18 '21 17:10 szuecs

@szuecs yes it's make sense when we have different ingress and we define via the annotatoin then it will end up in 2 stack one with waf and another without. What my concern is am starting waf association globally yes at the end there will be only one stack. Why we're creating new stack for global association?

janavenkat avatar Oct 19 '21 09:10 janavenkat

@janavenkat sounds like a maybe bug. Does it hurt?

szuecs avatar Oct 19 '21 13:10 szuecs

@szuecs yeah am wondering we could do the association, de-association without create a new stack?

janavenkat avatar Oct 19 '21 14:10 janavenkat

I guess in theory yes and it's an optimization of course

szuecs avatar Oct 19 '21 16:10 szuecs

@janavenkat sounds like a maybe bug. Does it hurt?

It's hard to say it's a bug, it does the work the only problem i see it creates new stack. can we have this in optimization list?

janavenkat avatar Oct 20 '21 08:10 janavenkat