graphql-jit icon indicating copy to clipboard operation
graphql-jit copied to clipboard

[RFC] compile createSourceEventStream

Open Dschoordsch opened this issue 3 years ago • 7 comments

Creating a source event stream from the compiled query is about 1.5 to 2 times faster. The use case for createSourceEventStream is running the event stream and resolvers in different processes. That means compiling the resolvers is not necessary and just costs performance, thus a separate function is exposed for just this use case. It does not actually compile anything, but that's an implementation detail und thus compileCreateSourceEventStream name was chosen.

This needs some polishing and tests, but I would like to know if you're interested in this at all?

Relates-To: https://github.com/ParabolInc/parabol/issues/5468

Dschoordsch avatar Dec 07 '21 08:12 Dschoordsch

@markrzen could you take a look and let me know if this is something you would be willing to accept? If yes, I will polish it up.

Dschoordsch avatar Dec 09 '21 11:12 Dschoordsch

Hey @Dschoordsch, I am not a maintainer of the library. You will want to ping the good folks on this list: https://github.com/zalando-incubator/graphql-jit/blob/main/MAINTAINERS

markrzen avatar Dec 09 '21 16:12 markrzen

I wont have time before the weekend to check it.

ruiaraujo avatar Dec 09 '21 16:12 ruiaraujo

@ruiaraujo did you have chance to take a look whether or not a compileCreateSourceEvent function would be something you would accept?

Dschoordsch avatar Dec 14 '21 16:12 Dschoordsch

@boopathi could you take a look if that's something which you would be interested in?

Dschoordsch avatar Jan 05 '22 09:01 Dschoordsch

@Dschoordsch We would like to learn if there are more needs for this in the GraphQL JIT user community

oporkka avatar May 24 '22 14:05 oporkka