wkhtmltopdf_binary_gem icon indicating copy to clipboard operation
wkhtmltopdf_binary_gem copied to clipboard

Add support for x386 debian 11/12, amd64 debian 11/12, arm64 debian9/10/11/12 with test

Open willnet opened this issue 2 years ago • 10 comments

  • Added binaries for x386 debian 11/12, amd64 debian 11/12, arm64 debian9/10/11 and made them available for testing on GitHub Actions
    • Since we can't select arm64 platform in GitHub Actions on github.com, use docker/setup-qemu-action to virtually realize testing on arm64.
    • It was difficult to use the same docker-compose.yml and Dockerfile for x86 and arm64, so create docker-compose.yml and Dockerfile for arm64 version.
  • Since we are using docker to test on x86 ubuntu, we don't need multiple versions of Ruby on ubuntu, so we only use one version of Ruby.
  • Fixed a bug that the order of arguments of assert_equal method was reversed.
  • Loosened conditions for passing the test
    • Only 0.12.6.1 binaries are available under newer distributions such as debian11, so make the tests pass.
  • Add Ruby 3.2 to CI matrix
  • Fix a broken archlinux test
    • Fix an error that the libssl library could not be found
  • update github actions

willnet avatar Aug 08 '22 08:08 willnet

This would close #121, #122 and #146.

I added the line

gem 'wkhtmltopdf-binary', git: 'https://github.com/willnet/wkhtmltopdf_binary_gem.git', branch: 'arm'

…to my Gemfile and it works as expected with Docker (ruby:2.6.6-buster) on my Apple Silicon Mac. No more hacks necessary.

If you have a minute – @pedrofurtado and @unixmonkey – I would greatly appreciate your attention on this PR.

LeEnno avatar Nov 08 '22 14:11 LeEnno

Add binaries for debian11.

willnet avatar Feb 10 '23 13:02 willnet

a test failure about archlinux is resolved by #156

willnet avatar Feb 10 '23 13:02 willnet

Would love to see this one get merged into the main repo!

jeffbax avatar May 24 '23 14:05 jeffbax

Hey guys,

any news here?

slayer avatar Jul 11 '23 08:07 slayer

up

mikekosulin avatar Jul 24 '23 11:07 mikekosulin

I have added debian12 binaries.

Now debian9 fails to build, does anyone know a good solution for this?

willnet avatar Nov 21 '23 14:11 willnet

I have added debian12 binaries.

Now debian9 fails to build, does anyone know a good solution for this?

Issue is due to End of Life (EOL). Please check out my PR

mikekosulin avatar Nov 21 '23 17:11 mikekosulin

I made a new repo and merged the MR from @willnet https://github.com/matthiaz/wkhtmltopdf_binary_gem

I then pushed a new gem: https://rubygems.org/gems/wkhtmltopdf-binary-ng/versions/0.12.6.6 so it can be used by others

So in stead of using gem install wkhtmltopdf-binary you could use gem install wkhtmltopdf-binary-ng and roll with that.

Apart from this MR, nothing else was changed in the gem. But we could, if this repo stays stale...

matthiaz avatar Dec 08 '23 12:12 matthiaz

@zakird @pedrofurtado @unixmonkey is any of you maintaining this repo? Any thoughts or decision on this?

bernica avatar Dec 21 '23 18:12 bernica

Thank you! These contributions are now in version 0.12.6.7. Please check it and make sure it still works for you. I really appreciate you taking the time to fix the CI issues, and bringing over a bunch of the arm64 binaries.

unixmonkey avatar May 10 '24 02:05 unixmonkey