Baptiste Fotia
Baptiste Fotia
I applied the polymorphism principle for the main groups for a Workspace (WM- and U-).
I created a new API/REST to get a space by name.
If the "share with gorup members only" is checked, the GeneralManager is not able to add users to the Workspace Manager group. @smarinier, don't accept my PR for the moment,...
I splitted the linter php part in another file that is "lint-php.yml".
The url for routes are misnamed and confused. Here is an example of a better way : ``` /workspaces (GET, POST) /workspaces/ (GET, DELETE, PATCH) /workspaces//groups (POST, GET) /workspaces//groups/ (GET,...
- [ ] Create a Format Groups or Workspace class to unify the "spaces" object Hey @dorianne-arawa :wave:
This issue follows the request of p-bo : https://github.com/arawa/workspace/pull/541#issuecomment-1253569732 Where it is to open the workspace translations on transifex. I have to read this doc : https://docs.nextcloud.com/server/latest/developer_manual/basics/front-end/l10n.html#adding-translations
It's very interesting could check the checkbox and add the GeneralManager and the WorkspacesManagers with this funciton : https://github.com/nextcloud/server/blob/18431c2fe920c1f72f68f3c33a7c2a40ccb70c0a/lib/public/App/IAppManager.php#L125
It's very interesting to test the pesence of Groupfolders app with IAppManager before using or installing of the Workspace app :point_right: https://github.com/nextcloud/server/blob/18431c2fe920c1f72f68f3c33a7c2a40ccb70c0a/lib/public/App/IAppManager.php#L84
- [ ] Don't rename the groups added - Example: I added the `DRH` group from AD. It will not be renamed to `DRH-110`. Whatever the type (from AD or...