jogging icon indicating copy to clipboard operation
jogging copied to clipboard

Example from the docs doesn't work

Open beniwohli opened this issue 15 years ago • 1 comments

The advanced example in the docs doesn't work as advertised. The view-specific logger 'myapp1.views.super_important_view' doesn't actually catch anything, because sys._getframe(1).f_globals['__name__'] as used in jogger.__init__ only returns the module and does not include the name of the view. I modified it to this:

caller = '%s.%s' % (sys._getframe(1).f_globals['__name__'], sys._getframe(1).f_code.co_name)

This code works for view functions (enough for me), but for methods, it doesn't include the name of the class, so there is still room for improvement.

beniwohli avatar Mar 17 '10 22:03 beniwohli

This is a hack anyway. It really needs to be rethought. Any python modules that are more than 1 directory deep won't work with the current implementation.

ianlewis avatar Apr 16 '10 01:04 ianlewis