Zaidoon Abd Al Hadi

facebook pr to expose the c api has been merged: https://github.com/facebook/rocksdb/pull/12262 will create the rust bindings once the c binding changes land in the rocksdb release

This also LGTM, adding tests would be great

> I can write some tests, but it might take a while until I get to it depending on how deep these tests should go: I'm unfortunately rather short on...

@tisonkun I typically work on things that I need to use due to time constraints. This feature is not one of them, however, If you create a pr, I'm happy...

> It also looks like RocksDB will not directly use jemalloc even if ROCKSDB_JEMALLOC is defined, the allocator needs to be set explicitly using `void rocksdb_lru_cache_options_set_memory_allocator(rocksdb_lru_cache_options_t* opt, rocksdb_memory_allocator_t* allocator)` (and...

my current change (while not ideal because it doesn't link to jemalloc used by tikv but relies on the system jemalloc) does get rocksdb to recognize jemalloc because when i...

I tried: ``` if cfg!(feature = "jemalloc") { config.define("WITH_JEMALLOC", "ON"); if let Some(jemalloc_root) = env::var_os("DEP_JEMALLOC_ROOT") { config.include(Path::new(&jemalloc_root).join("include")); } } ``` and that didn't get malloc stats to work I also...

> No, that seems good, it builds for me locally. ok to be clear, I tried that on my mac and that failed, let me try on linux which is...

ok confirmed working on linux!

it looks like what we want to do is something similar to what tikv rust-rocksdb does;https://github.com/tikv/rust-rocksdb/blob/05fc3f80ed50bac9932ca238e9dfbaadb7390965/librocksdb_sys/build.rs#L26C7-L26C26 to make sure the build doesn't fail on mac when trying to enable jemalloc....