Zafrir Ron

Results 20 comments of Zafrir Ron

Also consider running HTML validator on index.html (use https://validator.w3.org), I've cleaned some errors using it....

The new added "feedback" function (sending map in actions), I suggest to allow other actions than "feedback" and add property (for backwards compatibility, I've added the two as last function...

**Leaflet V1.4** BTW - after working extensively for quite some time already with V1.4, I have not experienced any issues related to v1.4 so far....

For the new context menu option, while most of the html panel configuration and parameters should be set by server nodes. The only internal "map" parameter is the click position...

> yes I have a 1.4 branch (leaflet-upgrade) almost ready to go... just "baking" it for a while to check before releasing it as beta. > Will run html check...

> so function(n,v,(optional a)) would be ok and then send {action:a||"feedback", name:n, value:v} Sure, thanks!

> PS - I published the v2.0.0-beta to npm which uses leaflet 1.4.x if you wish to try it. Thanks, I'will. (unfortunately. since I already forked away....my merges back are...

Thanks! I'm not sure, but isn't leaflet rectangle object type handled by "worldmap"? (only as polygons?)... use cases: 1. Rectangle attributes are special (were bounding box needed) 2. I'm adding...

Rectangles: since leaflet draw has two different shapes for rectangles and polygons, maintaining leaflet conventions should be a good reason... Editing a rectangle is different from editing a polygon in...

Ok.... the contextmenu injection hoever also may have the same vanurability as it allows html forms including javascript....