jsemver
jsemver copied to clipboard
zafarkhaja
Allow for long versions.
Our tests use currentTimeMilliseconds in the patch version to check for longer version. It will be convenient if we can use long versions, as they are accepted in ordinary npm-registries.
Wow, I just looked at the open pull requests and found that there's a PR open with almost exactly the same changes as mine. Would you prefer I change version numbers from int to BigInteger? Or some other arbitrary-precision number? I'd be glad to 😄 !
This would be in any case a backwards compatibility breaking change as the return type signature of the public API of the library would change. Merging this change would require an increment in the major Version and release notes with a migration path would be nice.
@Simulant87 that's what's good about 0.y.z (initial development) version, you don't have to commit to backward compatibility before you feel the API is stable enough. You get to try different things and gather feedback.
Hello Larry, I hope you're doing well!
Sorry it took me this long to get back to you.
I appreciate you taking the time and effort to contribute, but unfortunately this change is incomplete and doesn't cover all the bases. I wasn't sure if you'd be still interested in completing it, and, anyway, wanted to speed things up to clear the backlog as soon as possible, so I went ahead and implemented the feature myself (017ffe7). For now I went with the long.
Have a nice day,