jsemver icon indicating copy to clipboard operation
jsemver copied to clipboard

Published 20 hours ago • verified publisher icon zafarkhaja

All version classes should be serializable

Open rbellamy opened this issue 8 years ago • 3 comments

Serializable version classes with unit test

This change is Reviewable

rbellamy avatar Aug 20 '16 02:08 rbellamy

@zafarkhaja my PR is not the oldest on your list, so by no means am I trying to jump ahead in line - this is just a gentle ping to find out if you have any idea when you'll have a chance to merge these outstanding PR's?

rbellamy avatar Oct 30 '16 05:10 rbellamy

@zafarkhaja - any word at all?

rbellamy avatar Apr 21 '17 06:04 rbellamy

Gah, this is why GitHub Organizations are so useful. Once again, another project that is essentially dead because the original author couldn't be bothered...

rbellamy avatar Oct 25 '17 21:10 rbellamy

Hello Richard, I hope you're doing well!

Your frustration was valid, and I'm sorry it took me this long to get back to you.

I appreciate you taking the time and effort to contribute, however I'd prefer serialization proxy pattern to using the default serialized form. I wasn't sure if you'd be still interested to resubmit, and, anyway, wanted to speed things up to clear the backlog as soon as possible, so I went ahead and implemented the feature myself (8c22fdf).

Have a nice day,

zafarkhaja avatar Apr 11 '23 07:04 zafarkhaja