Michael Macias

Results 68 comments of Michael Macias

> I've just been reading through the VCF specification, and I can't see that it requires the ID values for the predefined structured metadata lines be unique It was clarified...

> I think reasonable behaviour would be [...] to keep the first one and ignore subsequent ones. This is what htslib does for all VCF versions. E.g., ``` $ cat...

~~Note that [UTS #18: Annex C](https://unicode.org/reports/tr18/#Compatibility_Properties) suggests `:print:` character class compatibility for Unicode as `\p{graph}\p{blank}--\p{cntrl}`, which is likely not the appropriate definition here since it includes `:blank:`. It may be...

Ah, yes, you're right. I had a set operation wrong when I tested with an example. `:print:` seems sufficient for this change.

In summary, https://github.com/samtools/hts-specs/commit/94500cf76f049e898dec7af23097d877fde5894e now recommends platform values to be in written in uppercase. They _can_ be parsed as either uppercase or lowercase but not mixed case, e.g., `ILLUMINA` is always...

Thanks for the heads up. I'll watch the hts-spec issues for further updates. > I see the [BAM encoder](https://github.com/zaeleus/noodles/blob/master/noodles-bam/src/record/codec/encoder/sequence.rs#L48-L69) disallows U. noodles-bam does accept U as per the SAM/BAM specification...

> There is no issue with a particular tagged or header field defined later appearing in a SAM/BAM/etc file that declares an earlier `@HD VN` version... For example, `@SQ AH`...

There also exists a related failed test case that disallows MISSING in a list of filters: [`test/vcf/4.3/failed/failed_body_filter_000.vcf`](https://github.com/samtools/hts-specs/blob/144e32acb582b414a281bf9dc06223b43609a489/test/vcf/4.3/failed/failed_body_filter_000.vcf).

When dealing with a format record, the `AsRef` implementation does return the underlying raw data from the record. In [`sam::record::QualityScores`](https://docs.rs/noodles/0.99.0/noodles/sam/record/struct.QualityScores.html), these are the ASCII encoded scores (score + offset); in...

> ERROR: recipes/fq/meta.yaml:6: in_other_channels: A package of the same name already exists in another channel There is a name collision in conda-forge: https://anaconda.org/channels/conda-forge/packages/fq/overview. This is not the same package. What...