trilium icon indicating copy to clipboard operation
trilium copied to clipboard

Published 20 hours ago • verified publisher icon zadam

Fix math panel overflow - closes #2056

Open abitofevrything opened this issue 3 years ago • 8 comments

The issue was originally caused by the math plugin only allowing the balloon to show up below the target. This pull request allows it to show on top as well, fixing the overflow issue.

abitofevrything avatar Jul 24 '21 22:07 abitofevrything

Hi, wouldn't it be better to fix this in the upstream - https://github.com/isaul32/ckeditor5-math ? It would then benefit all projects using this plugin ...

zadam avatar Jul 25 '21 09:07 zadam

It seems the issue was added in this commit.

I will open an issue there and see if this is intentional.

abitofevrything avatar Jul 25 '21 11:07 abitofevrything

Any update on this? I'm having the same issue and upstream for the project seems a bit dead as of right now. I can add extra lines to the end but would prefer the additional polish that comes with the software fixing it for me.

otisdog8 avatar Aug 26 '21 00:08 otisdog8

Any update on this?

Not from my side.

zadam avatar Aug 26 '21 18:08 zadam

Any chance of merging this?

otisdog8 avatar Aug 26 '21 18:08 otisdog8

I still believe it would be much better to fix this upstream.

zadam avatar Aug 26 '21 19:08 zadam

I agree that it would be better but upstream hasn't responded to the issue, and the owner of the repository hasn't had activity since May. This bug has been in trilium for at least two months and nothing has been done to fix it (except for a pull request that fixes the issue), and there are no drawbacks from at least merging this temporarily. I agree that it would be much better to fix this upstream, but we should still fix it in the meantime.

otisdog8 avatar Aug 26 '21 21:08 otisdog8

Any updates about this? The author of the plugin seems to be active again as he published a new release a month ago.

chianti-ga avatar Mar 13 '23 11:03 chianti-ga