Zachary Ruiz

Results 12 comments of Zachary Ruiz

@akiratwang Oops, I hope i didn't mess anything up. I followed the instructions here: https://github.com/amundsen-io/amundsen/pull/1836/checks but maybe I shouldn't have.

@feng-tao I started to rebase but there were so many merge conflicts and a few of them I wasn't sure about. Since this PR is just one file, maybe I...

@feng-tao @akiratwang I fixed up my fork of amundsen and re-created this PR on a clean main branch. https://github.com/amundsen-io/amundsen/pull/1877

Thanks so much @chonyy. I have an update in progress that addresses all three, hope to have it committed in the next day or so.

Awesome @chonyy . Agreed on the upper case. Can we assume the headers of the CSV files will always be upper case?

Also, I am out of town this week, but here is the error handling code that goes right after session.run() in _execute_statement() ret = [dict(i) for i in result] if...

@mgorsk1, @chonyy, @dkunitsk I created a version of the publisher that uses UNWIND and APOC library. It's 5x faster for me on my test dataset (1500 tables, 650k columns). Still...

Wasn't sure if I am allowed to make a branch in the main repo or if I am supposed to fork first. Hopefully you can see this, I did it...

Great to hear! Our testing has been going well - we have been using this class for all publishes the last month and haven't seen any issues. I was hoping...

Awesome @akiratwang, so glad it worked well. I opened a PR here: https://github.com/amundsen-io/amundsen/pull/1836. If you want to add anything to it go for it; I am not sure how to...