Zack Weinberg

Results 131 comments of Zack Weinberg

Also, just to verify, the `xcrypt_symbol` annotations are no longer necessary with this version of the patch?

Can we get a CI build with all hashes enabled, LTO on, and ASan+UBSan also on? That would be a quick way to get _some_ more confidence that the code...

Every time you force-push this branch, I get multiple emails from Codacy about the missing syntax-highlighting annotation in the README. It's making it hard for me to tell what actually...

Huh, I thought we already had an open wishlist item for argon2 but I guess we don't. We would certainly consider a patch or PR to add argon2. The main...

I'd be fine with libxcrypt growing an optional runtime dependency on libargon2.so, but is there a second independent implementation of Argon2 yet? This is desirable for verifying interoperability.

The [Argon2 draft RFC](https://datatracker.ietf.org/doc/draft-irtf-cfrg-argon2/history/) is in a late stage of the IRTF process and does not appear to have changed very much in some time. In particular the test vectors...

Good catch, thanks. Unfortunately I don't think libtool supports sonames like this at all. I've got an experimental branch in which we build with meson instead, and I'll see if...

A less wordy workaround is `cut -d \\ -f 2` but IMHO the warning should not trigger when the offending single-quoted shell word is exactly `'\'`.

The equivalent of ``` grep '[\d|\w|-]* \\' foo ``` with the trailing backslash outside the quotes, is ``` grep '[\d|\w|-]* '\\\\ foo ``` because you need to supply two backslashes...