Zack Proser

Results 37 comments of Zack Proser

@ellisonc Very nice work. This looks solid to me. Want to resolve the merge conflicts so I can approve?

@ellisonc would you like to do the honors of merging and releasing per the instructions [here](https://github.com/gruntwork-io/cloud-nuke#releasing-new-versions)?

Agree - this certainly makes sense to me as a feature to add. PRs to add this functionality in are very welcome, as we're pretty buried right now.

@radicarl do you want to give the PR linked above a shot? If you're on GitHub free, then the `--reviewers` flag should work for you now.

@radicarl Give it a shot and let me know how it works!

I'm going to close this ticket out due to inactivity and because the underlying issue should have been resolved by recent changes.

Hi @rvc-mf - none of the folks you've pinged here work at Gruntwork any longer.

Thanks for the PR! Looks like a good start. Could you also please add tests to ensure this new functionality doesn't cause any issues? See https://github.com/gruntwork-io/terratest/commit/142b643d20c78afaaf4a5ab6687ff01a70aa7c21 for reference - it's...

> > @merkata this change set looks great to me, could you resolve the conflicts in the PR and add test cases for the new tagging feature? > > Thanks...

@merkata I see what you're saying. How about adding a new section header under the [`Excluding Resources by Age`](https://github.com/gruntwork-io/cloud-nuke#excluding-resources-by-age) header (or maybe right above it?)