ghidra-dark icon indicating copy to clipboard operation
ghidra-dark copied to clipboard

Published 20 hours ago • verified publisher icon zackelia

Some GUI elements are rendered unreadably

Open smithzvk opened this issue 2 years ago • 5 comments

This seems potentially related to #27, but it doesn't exactly look the same and the severity is quite a bit worse. I see the color theme applied to almost all areas I care about, but certain areas become unusable, for example the strings tab, the script manager, the keybinding configuration dialog. The text in these areas is rendered as slighly off-white against a white background. I suspect that this is an issue due to the general dark OS theme... I don't know, I'm out of my depth on this one.

OS: Pop_OS 21.10 Ghidra: 10.1.2 ghidra-dark: ab7ca3302dd4a8b12c6e093d388e87c6d7e214d5

image

image

image

image

image

smithzvk avatar Mar 12 '22 13:03 smithzvk

Same on MacOS. When this gets fixed, it's the perfect theme. Thanks! :)

1mansh0w avatar Apr 08 '22 12:04 1mansh0w

Yeah please help to fix

SreeVathsan32 avatar May 10 '22 07:05 SreeVathsan32

Any fixes up?

SiriusED avatar May 23 '22 13:05 SiriusED

These places can not be fixed with a tool like ghidra-dark as the values of things such as table colors are hard coded in Ghidra itself. Not all hope is lost though! There is an open PR that integrates the existing color theme in this repo with some fixes for the views mentioned in this issue and others: https://github.com/NationalSecurityAgency/ghidra/pull/4145

zackelia avatar May 24 '22 21:05 zackelia

@zackelia with this PR bug in function editor изображение

sr-tream avatar Jun 06 '22 03:06 sr-tream

The PR I mentioned before did not achieve the results that I was hoping for in theming. If Ghidra is updated in the future to support these fixes I am willing to address.

zackelia avatar Mar 29 '23 17:03 zackelia

See #38 for some exciting developments!

zackelia avatar Apr 29 '23 02:04 zackelia