zackattackz
zackattackz
Amended with test in `pkg/bindings/test/volumes_test.go`
Amended because codespell doesn't like "fo"
No problem @rhatdan, thanks for reviewing. Was pretty simple but nice way to poke around the code a bit. I amended to fix two failing tests that the stdout result...
There seems to be multiple different possible stderr messages volume rm can emit in the e2e volume_rm test. Either "Error: volume with name {name} not found: no such volume" or...
Ah ok so after looking more into it basically the new error messages that are coming up are due to GetVolume's implementations in boltdb and sqlite returning different error messages...
OK tests are green now. Amended to conditionally check db backend in tests to get expected outpuit. Also amended to add and fix a test in [test/system/160-volumes.bats](https://github.com/containers/podman/pull/24027/files/9ae856d4dd47e3dd8664b5d3f9215ad187bb0813#diff-8e27a9e0ab1eb9cc49e6d4ee7b86689bb5b76e4fc7d80187185b4470351b7845)
Hi @Luap99, thank you for reviewing. > blocking for now as we must verify how docker actually behaves Sorry forgot to look more into this. From a cursory look at...
To verify how docker behaves: Calling `docker volume rm` eventually calls into this `Remove` method, [which calls `Get`](https://github.com/moby/moby/blob/c7e42d855ec41c28702a1f6f6c2c28ecc7bd9424/volume/service/service.go#L155) and passes the name. Where [`Get` calls `getVolume`](https://github.com/moby/moby/blob/c7e42d855ec41c28702a1f6f6c2c28ecc7bd9424/volume/service/store.go#L666) Which you can see...
> Well there isn't a need to test all commands I meant more so that I'd need to also verify that other docker commands don't use partial names, I only...
I'd be interested if @vlk-charles is not