Zackary Scott

Results 16 comments of Zackary Scott

Hello, I am wondering if this is something that is currently being worked? I see that your implementation of getChildKeyPair in the file https://github.com/bloxbean/cardano-client-lib/blob/master/src/main/java/com/bloxbean/cardano/client/crypto/bip32/HdKeyGenerator.java contains most of the implementation that...

I have implemented some of the logic to start working on this, and I am getting the derivation for the chain code to come out correct. But, I am not...

@satran004 looking at the EC Math library and the implementation you used along with the BIP32 docs. I believe to derive the public key from a public key you will...

@satran004 thank you for the response. I was looking at the wrong BIP32 implementation. Sorry, I am new to the space, and I appreciate the pdf you provided. I will...

>[lighthouse/beacon_node/beacon_chain/tests/rewards.rs](https://github.com/sigp/lighthouse/blob/fc7f1ba6b94ac3300338aad4d5168aaac5df3fac/beacon_node/beacon_chain/tests/rewards.rs#L130) > >https://github.com/sigp/lighthouse/blob/fc7f1ba6b94ac3300338aad4d5168aaac5df3fac/beacon_node/beacon_chain/tests/rewards.rs#L130 > > async fn test_verify_attestation_rewards_base() { >is passing even though I have added block rewards seperately. @Gua00va I checked out the PR and ran locally. I am...

@Gua00va you may also want to remove line: https://github.com/sigp/lighthouse/blob/71ef86be46a82f1e9d044c790d46e081ef4ad2ec/beacon_node/beacon_chain/tests/rewards.rs#L143 This is due to you moving the slot in the while loop: https://github.com/sigp/lighthouse/blob/71ef86be46a82f1e9d044c790d46e081ef4ad2ec/beacon_node/beacon_chain/tests/rewards.rs#L167 The above line 143 would put you an...

> > > [lighthouse/beacon_node/beacon_chain/tests/rewards.rs](https://github.com/sigp/lighthouse/blob/fc7f1ba6b94ac3300338aad4d5168aaac5df3fac/beacon_node/beacon_chain/tests/rewards.rs#L130) > > > https://github.com/sigp/lighthouse/blob/fc7f1ba6b94ac3300338aad4d5168aaac5df3fac/beacon_node/beacon_chain/tests/rewards.rs#L130 > > > > > > async fn test_verify_attestation_rewards_base() { > > > is passing even though I have added block rewards...

@jimmygchen I am not sure what the issue is here. I can try to take a deeper look into the codebase soon, but I did come across something strange while...

@Gua00va I think the way the altair fork and later apply proposal rewards to balances and the way the phase0 apply proposal rewards may be different. I.e. altair applies change...

@Gua00va @jimmygchen I was able to get the test to pass by making adjustments. I started calculation at epoch 0, and I added proposal rewards into mapping to be calculated...