Zach McElrath

Results 11 comments of Zach McElrath

@kevinohara80 Can you take a look at this sometime soon?

@kevinohara80 Also if you are interested in having a co-maintainer to help with the occasional PR's like this for adding metadata types, I'm up for it.

@davidjbradshaw Did you get this working? Can this issue be closed?

@SantaHub I submitted a PR for this: https://github.com/shallwefootball/upload-s3-action/pull/58

@WoodyWoodsta Totally agree, but that would be a breaking change, and would need to be done in a major release. I was just preserving the previous default behavior. But I...

@WoodyWoodsta Make sense, which other action are you using?

@MrSwitch Never mind about the Vimeo thing --- I think it's better to retain the existing workaround code. My thought was that whoever is using the library could implement their...

@MrSwitch I think that would be fine, as long as it was called as late as possible in the respective login functions, i.e. just before URL-encoding of the body parameters...