MastodonRedirect icon indicating copy to clipboard operation
MastodonRedirect copied to clipboard

Authentication loopback

Open nhandt64 opened this issue 2 years ago • 11 comments

Hello, Currently I'm aware that this tooling app works too aggressively and that it also redirects authentication URLs from the mastodon clients back to themselves while in fact they can't handle authentication so they must open URLs in the browser. Have this on your checklist yet?

nhandt64 avatar Sep 11 '23 02:09 nhandt64

Do you know the exact URL your instance tries to authenticate with? The app is already supposed to force a browser launch when it sees oauth/authorize in the URL.

zacharee avatar Sep 11 '23 02:09 zacharee

So far I have tried mastodon.social, mstdn.jp, floss.social, mas.to and they all have the same URL pattern: <domain>/auth/sign_in. They all got caught by your app and sent back to the mastodon client.

Supposed the account has not been signed in the browser yet so it can't reach your oauth pattern. Maybe you haven't thought about this scenario yet?

nhandt64 avatar Sep 11 '23 02:09 nhandt64

Does 1.5.1 work?

zacharee avatar Sep 12 '23 01:09 zacharee

Hello,

I have tried both uninstalling and upgrading ways from version 1.5.0 to 1.5.1. However I cannot reproduce the fix when trying to login with aforementioned instances with Mastodon and Moshidon clients. I'm trying to test it out for you but my break time at college has ended. I will give it a try again and respond to you later.

Thanks for your hard work!

nhandt64 avatar Sep 12 '23 02:09 nhandt64

1.5.2 should hopefully fix it. I also added some other URL checks for some non-Mastodon instances.

zacharee avatar Sep 12 '23 15:09 zacharee

I am trying to add a new account to Fedilab, but always get redirected to the app when a browser should open instead. Using latest version.

nichu42 avatar Sep 15 '23 20:09 nichu42

Are you using Shizuku or LinkSheet?

And are you using Chrome or a Chromium-based browser?

zacharee avatar Sep 16 '23 00:09 zacharee

I have reset all links with Shizuku and uninstalled it afterwards. I am now using Linksheet Nightly. My standard browser is Firefox, but I have also tried Mulch and Chrome.

nichu42 avatar Sep 16 '23 06:09 nichu42

Same problem here using mastodon.social

I set up with Shizuku. Funnily enough I can't change Mastodon Redirect's settings to skip redirects for mastodon.social in the system settings – the settings app simply crashes, presumably as it's trying to load the list of websites that link to Mastodon Redirect..

Working around this by telling the browser not to open links in apps.

Thank you for the otherwise great app!

TechD123 avatar Oct 14 '23 22:10 TechD123

I can't reproduce the issue, so I can't really figure out how to fix it, but I've added a blocklist feature in 1.8.0, so you can turn off domains you don't want the app to handle even after they've been assigned to the app. Settings >> Link Blocklist.

zacharee avatar Oct 19 '23 22:10 zacharee

Wow I finally found what made my phone completely crash while trying to authenticate to my account with pixelfed app. Giving a try to kaiteki app, I got a simple crash on oauth conversation. After investigating on firefox version, webview/chrome updates, default browser parameters, during few hours, I finally removed MastodonRedirect and this is it ! Everything work like a charm ! This is a real issue, because I need your app, very useful, but the interaction was really crashing completely my phone (reboot with failsafe menu) ! Now I can reinstall it btw :)

pguimier avatar Oct 31 '23 15:10 pguimier